Closed
Conversation
Changes:
Total lines: 4862 (+124) |
deployed preview: https://617.connect-d5y.pages.devWelcome to connect! Make sure to:
|
Mahdi451
force-pushed
the
fix-geocode-test-flake
branch
from
5713807 to
3d241d4
Compare
Author
|
@incognitojam I’m still fairly new here, so any feedback on this PR would be really appreciated. |
Author
|
Closing this in favor of the fork-owned integration PR: Mahdi451#1 . The combined branch includes the geocode test fixes plus the fork preview changes that will be validated in that preview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stabilizes the geocode tests by replacing live Mapbox-dependent assertions with deterministic mocked responses. It also keeps the test job timeout at 2 minutes, since recent runs are already brushing up against the old 1-minute limit. Production geocoding behavior is unchanged.
The tests now cover the early return near
[0, 0], request construction, normal address and place-name lookups, failure cases, and place-name fallback behavior.Testing: